<html>
<head><meta charset="utf-8"><title>Meeting 2021-02-09 · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html">Meeting 2021-02-09</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="225662545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225662545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225662545">(Feb 09 2021 at 09:27)</a>:</h4>
<p>Placeholder for today's meeting <time datetime="2021-02-09T04:00:00Z">2021-02-09T05:00:00+01:00</time></p>
<p>Agenda:</p>
<ul>
<li>Triage (as always)</li>
<li>Configuration file for lints project needs mentor (preferably not me)</li>
<li><code>_</code></li>
</ul>
<p>Got anything else? Just comment below!</p>



<a name="225687629"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225687629" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225687629">(Feb 09 2021 at 13:18)</a>:</h4>
<p>I believe the lintcheck tool is mostly feature complete now, we should be able to set up a custom embark_sources.toml that checks all the embark crates (be it git repos or <a href="http://crates.io">crates.io</a> releases).<br>
It would override the current lintcheck results though but that one is saved in the git repo anyway.</p>



<a name="225696232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225696232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225696232">(Feb 09 2021 at 14:23)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> We (embark) can collect a list of repos for you if you need. Can we also run lintcheck in our own private repo so we that we can test our private repos?</p>



<a name="225698387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698387">(Feb 09 2021 at 14:36)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span>  if you have a clone of the clippy repo,  you can edit <br>
<a href="https://github.com/rust-lang/rust-clippy/blob/master/clippy_dev/lintcheck_crates.toml">https://github.com/rust-lang/rust-clippy/blob/master/clippy_dev/lintcheck_crates.toml</a><br>
to only include the crates you want to check.<br>
Then run (in the clippy repo root) <code>cargo dev-lintcheck</code>.<br>
In the end you should see lintcheck-logs/logs.txt with the lint results of the listed crates.</p>



<a name="225698516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698516">(Feb 09 2021 at 14:37)</a>:</h4>
<p>If you commit that, and later rebase and re-run, you should see the log-diff in the repo about new clippy warnings popping up or some old ones disappearing. :)</p>



<a name="225698622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698622">(Feb 09 2021 at 14:38)</a>:</h4>
<p>Not sure what the lintcheck is about exactly, but I have some more crates that are stable-clippy-clean and generally of pretty good quality if that helps.</p>



<a name="225698658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dirkjan Ochtman <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698658">(Feb 09 2021 at 14:38)</a>:</h4>
<p>(maybe there should be README and or some comments in the <code>crates.toml</code>?)</p>



<a name="225698696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698696">(Feb 09 2021 at 14:39)</a>:</h4>
<p>There will probably be merge conflicts if the original <code>logs.txt</code> file  gets updated in the meantime, maybe we'll need an option to print to a custom log file...</p>



<a name="225698984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225698984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225698984">(Feb 09 2021 at 14:41)</a>:</h4>
<p><span class="user-mention" data-user-id="226095">@Dirkjan Ochtman</span> we could add some of them I guess..? :)<br>
The current selection was mostly me looking at whats interesting/popular on <a href="http://crates.io">crates.io</a> and what rustc compiles (as a test) in CI.<br>
And yeah, I'll need to add some kind of readme.</p>



<a name="225699214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225699214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225699214">(Feb 09 2021 at 14:42)</a>:</h4>
<p>Heh, noticed tokei is commented out. Probably around the same I stopped listening to clippy <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="225700425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225700425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225700425">(Feb 09 2021 at 14:50)</a>:</h4>
<p>ah right.. <code>tokei-f53c6c99bba5e56b/out/language_type.rs</code> ... it causes 173K  <code>clippy::match_same_arms</code> warnings <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="225703445"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225703445" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225703445">(Feb 09 2021 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span>  Oh no <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> , it shouldn't really be linted, as that's auto-generated by a build script. A lot of those warnings are things like the following. I used to try and deduplicate it, but then I was like "eh, let the compiler figure it out." <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> </p>
<div class="codehilite"><pre><span></span><code>match language_type {
     LanguageType::Rust =&gt; &quot;//&quot;,
     LanguageType::C =&gt; &quot;//&quot;,
}
</code></pre></div>



<a name="225709051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225709051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225709051">(Feb 09 2021 at 15:45)</a>:</h4>
<p>Meeting in T-15.</p>



<a name="225711495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225711495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225711495">(Feb 09 2021 at 16:00)</a>:</h4>
<p>Meeting time! <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<a name="225711636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225711636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225711636">(Feb 09 2021 at 16:01)</a>:</h4>
<p>As always: First item triage. Any remarkable issues or PRs before the sync?</p>



<a name="225711918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225711918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225711918">(Feb 09 2021 at 16:03)</a>:</h4>
<p>Still waiting on two compiletest-rs PRs to be merged, but not sure who to ping about that. Not sure if Manish has commit access there and if they're available? (context: <a href="https://github.com/rust-lang/rust-clippy/issues/5394#issuecomment-770354992">https://github.com/rust-lang/rust-clippy/issues/5394#issuecomment-770354992</a>)</p>



<a name="225711988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225711988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225711988">(Feb 09 2021 at 16:03)</a>:</h4>
<p>(I see <span class="user-mention" data-user-id="220273">@Jane Lusby</span> is here. Congrats on the position as colab director <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> )</p>



<a name="225712074"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712074" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712074">(Feb 09 2021 at 16:03)</a>:</h4>
<p>I have commit!</p>



<a name="225712137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712137">(Feb 09 2021 at 16:04)</a>:</h4>
<p>This is for the bless command <span class="user-mention" data-user-id="197894">@Philipp Hansch</span>?</p>



<a name="225712155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712155">(Feb 09 2021 at 16:04)</a>:</h4>
<p>yup</p>



<a name="225712245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712245">(Feb 09 2021 at 16:04)</a>:</h4>
<p>Ok, this shouldn't be a sync blocker, should it?</p>



<a name="225712295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712295">(Feb 09 2021 at 16:05)</a>:</h4>
<p>no, I don't think so, it's all internal Clippy tooling</p>



<a name="225712524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712524">(Feb 09 2021 at 16:06)</a>:</h4>
<p>Also <span class="user-mention" data-user-id="360405">@Cameron Steffen</span> <span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> about triaging PRs: Please also ping reviewers if they abandoned a PR for too long to remind them. I saw today, that I should take another look at some PRs I'm assigned to. A reminder now and then would really help.</p>
<p>Otherwise <span class="user-mention" data-user-id="261224">@triagebot</span> end-topic</p>



<a name="225712525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712525">(Feb 09 2021 at 16:06)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="225712606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712606">(Feb 09 2021 at 16:07)</a>:</h4>
<p><span class="user-mention" data-user-id="197894">@Philipp Hansch</span> the bless code is just imported from upstream, yes?</p>



<a name="225712735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712735">(Feb 09 2021 at 16:08)</a>:</h4>
<p>Yes, I just added the test-suite thing myself <span aria-label="smiling face" class="emoji emoji-263a" role="img" title="smiling face">:smiling_face:</span></p>



<a name="225712805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712805">(Feb 09 2021 at 16:08)</a>:</h4>
<p>Ok next topic. <span class="user-mention" data-user-id="385097">@CPerezz</span> started working on a draft RFC for <a href="https://github.com/rust-lang/rust-clippy/issues/6625">clippy#6625</a> (config file for lints). It would be great if someone can mentor this work.</p>



<a name="225712976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225712976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225712976">(Feb 09 2021 at 16:09)</a>:</h4>
<p>This would involve working out an early draft that we can discuss as a team. So shouldn't be much work. So any volunteers would be appreciated! The draft can be found here: <a href="https://hackmd.io/@flip1995/HJteAAPgO">https://hackmd.io/@flip1995/HJteAAPgO</a></p>



<a name="225713119"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713119" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713119">(Feb 09 2021 at 16:10)</a>:</h4>
<p>I don't have anything else on this topic, just want to make you guys aware, that this is going on <span class="user-mention" data-user-id="261224">@triagebot</span> end-topic</p>



<a name="225713120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713120">(Feb 09 2021 at 16:10)</a>:</h4>
<p>Does anyone have something to add on the current topic?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if not.</p>



<a name="225713228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713228">(Feb 09 2021 at 16:11)</a>:</h4>
<p>Next <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> noted that the lintcheck tool is now (nearly?) feature complete. Any open questions <span class="user-mention" data-user-id="217864">@matthiaskrgr</span> ?</p>



<a name="225713438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713438">(Feb 09 2021 at 16:12)</a>:</h4>
<p>I tried to add a small readme on how to use it here; <a href="https://github.com/rust-lang/rust-clippy/pull/6708/files#diff-21884b161cddd86de6be0873790ac8a0be0401e3d937931cc42ddc405794c78f">https://github.com/rust-lang/rust-clippy/pull/6708/files#diff-21884b161cddd86de6be0873790ac8a0be0401e3d937931cc42ddc405794c78f</a><br>
(the mega-command is a bit awful to look at though :/ )</p>



<a name="225713494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713494">(Feb 09 2021 at 16:13)</a>:</h4>
<p>it would be nice if we could somehow run this on gha via a cron job daily somehow (maybe in a test repo)</p>



<a name="225713514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713514">(Feb 09 2021 at 16:13)</a>:</h4>
<p>but thats a task for another day I guess</p>



<a name="225713524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713524">(Feb 09 2021 at 16:13)</a>:</h4>
<p>I thought about, if it would make sense to open a separate repository, that just holds a list of crates and the logs. This may simplify the process of adding crates to that repository. People could than just submit a PR to add their crate there.</p>



<a name="225713547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713547">(Feb 09 2021 at 16:13)</a>:</h4>
<p>Yeah I would prefer a separate repo</p>



<a name="225713566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713566">(Feb 09 2021 at 16:13)</a>:</h4>
<p>rust-fuzz has a separate "targets" repo</p>



<a name="225713586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713586">(Feb 09 2021 at 16:13)</a>:</h4>
<p>we don't have a cron job but ... same deal</p>



<a name="225713597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713597">(Feb 09 2021 at 16:13)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="225713692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713692">(Feb 09 2021 at 16:14)</a>:</h4>
<p>if you have some ideas on what further packages to add to the test-list, let me know :)</p>



<a name="225713732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713732">(Feb 09 2021 at 16:14)</a>:</h4>
<p>The CI could look like this: If someone adds a repo it is tested on CI. and only merged if it passes without warnings. But the CI doesn't run tests on all other repos all the time, soo we don't exhaust GHA.</p>



<a name="225713751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713751">(Feb 09 2021 at 16:14)</a>:</h4>
<p>I think it might be worth to add an alias to cargo (via <code>.cargo/config</code>) for the long command you mentioned is there anything that speaks against this <span class="user-mention" data-user-id="217864">@matthiaskrgr</span></p>



<a name="225713912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713912">(Feb 09 2021 at 16:15)</a>:</h4>
<p>If we do open a separate repo, should we open it directly in rust-lang org or (first) open it under some user and move it if it's ready <span class="user-mention" data-user-id="132040">@Manish Goregaokar</span></p>



<a name="225713981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225713981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225713981">(Feb 09 2021 at 16:16)</a>:</h4>
<p><span class="user-mention" data-user-id="369415">@xFrednet</span>  <code>cargo dev-lintcheck</code> is that command :P<br>
It just does not set a custom crates.toml</p>



<a name="225714152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714152">(Feb 09 2021 at 16:17)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/.cargo/config#L4">https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/.cargo/config#L4</a></p>



<a name="225714275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714275">(Feb 09 2021 at 16:17)</a>:</h4>
<p>Could this be solved by using an environment environment value like uitest does with <code>TESTNAME</code> <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="225714677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714677">(Feb 09 2021 at 16:18)</a>:</h4>
<p>like <code>LINTCHECK_TOML</code> ?</p>



<a name="225714737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714737">(Feb 09 2021 at 16:19)</a>:</h4>
<p>The last point I have here would be, if we should write a blog post to ask people to submit their repos (once we set up a separate repo)?</p>



<a name="225714744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714744">(Feb 09 2021 at 16:19)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/257328-clippy/topic/Meeting.202021-02-09/near/225714677">said</a>:</p>
<blockquote>
<p>like <code>LINTCHECK_TOML</code> ?</p>
</blockquote>
<p>If it works yes <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="225714897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225714897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225714897">(Feb 09 2021 at 16:20)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> mmh, I don't know how many projects we will end up with... 100? <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="225715030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715030">(Feb 09 2021 at 16:21)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> directly rust-lang</p>



<a name="225715049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715049">(Feb 09 2021 at 16:21)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> but call it clippy-foo or something</p>



<a name="225715069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715069">(Feb 09 2021 at 16:21)</a>:</h4>
<p>I mean we want as many as possible, I guess.</p>



<a name="225715187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715187">(Feb 09 2021 at 16:22)</a>:</h4>
<p>Hmm, unsure about the blog post but it's probably fine</p>



<a name="225715205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715205">(Feb 09 2021 at 16:22)</a>:</h4>
<p>i'd check with infra if we're okay with soliciting crates for such a thing</p>



<a name="225715332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715332">(Feb 09 2021 at 16:23)</a>:</h4>
<p>Well there already is a big list of rust repos that is used to feed crater runs :) <a href="https://github.com/rust-lang/rust-repos">https://github.com/rust-lang/rust-repos</a></p>



<a name="225715386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715386">(Feb 09 2021 at 16:23)</a>:</h4>
<p>I mean, we want mainly crates, that adhere to Clippy's recommendations. Picking them by hand could be quite difficult.</p>



<a name="225715391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715391">(Feb 09 2021 at 16:23)</a>:</h4>
<p>If we get a lot of crates we could also split them up into a group that runs often and one that only runs per release/sync</p>



<a name="225715402"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715402" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715402">(Feb 09 2021 at 16:23)</a>:</h4>
<p>also the more repos we add, the more triage will have to be done...</p>



<a name="225715492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Manish Goregaokar <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715492">(Feb 09 2021 at 16:24)</a>:</h4>
<p><span class="user-mention" data-user-id="264664">@flip1995</span> makes sense to me!</p>



<a name="225715638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715638">(Feb 09 2021 at 16:25)</a>:</h4>
<p>We could look into some criteria for crates that can be submitted. E.g. LoC, amount of downloads... to limit the submissions.</p>



<a name="225715811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715811">(Feb 09 2021 at 16:26)</a>:</h4>
<p>But I think we can discuss details offline. Action items:</p>
<ul>
<li>Open repo to run lintcheck on a wider scale</li>
<li>find mentor for <a href="https://github.com/rust-lang/rust-clippy/issues/6625">clippy#6625</a></li>
</ul>
<p><span class="user-mention" data-user-id="261224">@triagebot</span> end-meeting</p>



<a name="225715816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715816">(Feb 09 2021 at 16:26)</a>:</h4>
<p>Does anyone have something to bring up?<br>
React with <span aria-label="working on it" class="emoji emoji-1f6e0" role="img" title="working on it">:working_on_it:</span> if you have something to say.<br>
React with <span aria-label="all good" class="emoji emoji-2705" role="img" title="all good">:all_good:</span> if you're ready to end the meeting.</p>



<a name="225715913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225715913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> xFrednet <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225715913">(Feb 09 2021 at 16:26)</a>:</h4>
<p>I have one more small update. Last time we had a discussion about assignment of new members to issues. The result was that we want to encourage the usage of <code>@rustbot claim</code> to give a better overview which issue is currently claimed.</p>
<p>I think this has improved over the last two weeks. It's a bit to early to really make a statement but the trend seems to be going up which is great in my opinion <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="225716006"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716006" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716006">(Feb 09 2021 at 16:27)</a>:</h4>
<p>Oh I also have a minor pain point</p>



<a name="225716077"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716077" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716077">(Feb 09 2021 at 16:28)</a>:</h4>
<p>the nighty that clippy is pinned to atm has a missing rustfmt component which means <code>cargo fmt</code> inside the clippy repo does not work</p>



<a name="225716198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716198">(Feb 09 2021 at 16:28)</a>:</h4>
<p>But I'm not sure how we could avoid that besides not syncing when rustfmt is missing from rustc nightly :/</p>



<a name="225716324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716324">(Feb 09 2021 at 16:29)</a>:</h4>
<p>hmm, something similar happened a few days ago: <a href="#narrow/stream/257328-clippy/topic/Issue.20with.20rustfmt">https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Issue.20with.20rustfmt</a> (may not be related though)</p>



<a name="225716327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716327">(Feb 09 2021 at 16:29)</a>:</h4>
<p>(I have to edit the <code>rust-toolchain</code> to use "nightly" every time, run <code>cargo fmt</code> and then check out the original toolchain file again)</p>



<a name="225716329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716329">(Feb 09 2021 at 16:29)</a>:</h4>
<p>I also noticed that. But it is only a problem, because <code>rustfmt</code> is in the <code>rust-toolchain</code> file. Do we really need it there? <code>cargo dev fmt</code> runs latest nightly <code>fmt</code> anyway.</p>



<a name="225716389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716389">(Feb 09 2021 at 16:29)</a>:</h4>
<blockquote>
<p>cargo dev fmt runs latest nightly fmt anyway.</p>
</blockquote>
<p>oooh</p>



<a name="225716505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716505">(Feb 09 2021 at 16:30)</a>:</h4>
<p>ok I didn't try that <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="225716530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716530">(Feb 09 2021 at 16:30)</a>:</h4>
<p>So in the fmt test <code>cargo +nightly fmt</code> is run. So just remove <code>rustfmt</code> from <code>rust-toolchain</code>?</p>



<a name="225716607"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716607" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716607">(Feb 09 2021 at 16:30)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/tests/fmt.rs#L11-L12">https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/tests/fmt.rs#L11-L12</a></p>



<a name="225716637"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716637" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716637">(Feb 09 2021 at 16:31)</a>:</h4>
<p>guess the worst thing that can happen is that the next sync will have to reformat some code or something <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="225716806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716806">(Feb 09 2021 at 16:32)</a>:</h4>
<p>I think CI will fail before that happens. And here are the commands that are run by <code>cargo dev fmt</code>: <a href="https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/clippy_dev/src/fmt.rs#L155-L168">https://github.com/rust-lang/rust-clippy/blob/03a0dd599dcb3f3ce7aee844b060a217bd25396b/clippy_dev/src/fmt.rs#L155-L168</a></p>



<a name="225716917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716917">(Feb 09 2021 at 16:32)</a>:</h4>
<p>So I think it's save to delete it from <code>rust-toolchain</code>. Let me do that real quick and see what CI thinks about it.</p>



<a name="225716970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225716970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Phil H <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225716970">(Feb 09 2021 at 16:33)</a>:</h4>
<p>CI may not work right now <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span> <a href="https://www.githubstatus.com/incidents/5qdkkyg958vy">https://www.githubstatus.com/incidents/5qdkkyg958vy</a></p>



<a name="225717158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Meeting%202021-02-09/near/225717158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Meeting.202021-02-09.html#225717158">(Feb 09 2021 at 16:34)</a>:</h4>
<p>But I think, that's really it for the meeting. </p>
<p>Thanks for attending <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>